Switch from puppet releases to openvox releases #227
Conversation
bastelfreak
force-pushed
the
db
branch
2 times, most recently
from
bc1f80c to
2628083
Compare
|
@binford2k do you want to have some kind of warning for Puppet AIO users here? Or in facterdb? Do you have anything specific in mind? |
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'm still not sure we need to drop the old Puppet stuff. Can't we start with a non-breaking release where we add OpenVox?
| end | ||
| end | ||
|
|
||
| def self.facter_version_for_puppet_version(puppet_version) |
There was a problem hiding this comment.
I don't mean to add on all the time, but I'd like to make this consistent and mention OpenVox. How about
| def self.facter_version_for_puppet_version(puppet_version) | |
| def self.openfact_version_for_openvox_version(openvox_version) |
And design wise: I really would appreciate a non-breaking release first (if possible). Then you may want to split out some version finding logic to a helper method.
I considered that. But that will make it hard to distinguish between puppet/openvox factsets. If you want I can just extend the existing json file with our versions. |
Since Perforce stopped building open source AIO packages, we're continuing the list with OpenVox/OpenFact builds. Alternative implementation for voxpupuli#227
Since Perforce stopped building open source AIO packages, we're continuing the list with OpenVox/OpenFact builds. Alternative implementation for voxpupuli#227
Since Perforce stopped building open source AIO packages, we're continuing the list with OpenVox/OpenFact builds. Alternative implementation for voxpupuli#227
4 participants
No description provided.